RFR(XS): 8150632: jdk.jshell.TaskFactory should use jdk.Version to check for java.specification.version

Volker Simonis volker.simonis at gmail.com
Thu Feb 25 12:11:32 UTC 2016


can I please have a review for the following small patch which fixes a
problem with the jshell java.specification.version check:


Currently, jdk.jshell.TaskFactory does a hard check against
java.specification.version being "9". Until JDK-8149519 [1] will be
resolved, this check will fail for any newer Java release (i.e.

But even if JDK-8149519 will be resolved, I think the compare should
actually check that java.specification.version is greater or equal to
"9". This can be easily done with the new jdk.Version API.

Thank you and best regards,

[1] https://bugs.openjdk.java.net/browse/JDK-8149519

More information about the compiler-dev mailing list