RFR (L) JEP 280: Indify String Concatenation (integration)

Paul Sandoz paul.sandoz at oracle.com
Wed Jan 27 16:31:21 UTC 2016

I think it quite reasonable to push everything to jdk9/dev.


> On 27 Jan 2016, at 14:55, Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
> Hi again,
> This is a formal pre-integration review thread for JEP 280 ("Indify
> String Concatenation") integration:
>   http://openjdk.java.net/jeps/280
> The JEP is Targeted, the CCC is approved, the code reviews and
> pre-integration checks are clean.
> Code changes are happening simultaneously in four components:
> a) (M) javac changes that emit indy:
>   http://cr.openjdk.java.net/~shade/8085796/webrev.langtools.05/
> b) (L) JDK changes with StringConcatFactory and friends, plus fixing
> the regression tests that do not expect additional indys:
>   http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.08/
> c) (XS) Build changes that force emitting the "legacy" inline
> StringBuilder concat in a few cases (e.g. when pre-JDK 9 bytecode is
> expected):
>   http://cr.openjdk.java.net/~shade/8085796/webrev.root.00/
> d) (XS) HotSpot changes that fix a GC regression test that now
> allocates some metaspace from within the test methods having a string
> concatenation:
>   http://cr.openjdk.java.net/~shade/8085796/webrev.hs.00/
> These changes were already reviewed by multiple people, and so I would
> like to keep the comments only for serious breaking issues at this
> point. (Note that this thread cross-posts over several mailing lists:
> bike-shedding discussion would get multiplied a lot!)
> Formal acknowledgements from Reviewers would be appreciated. Pending no
> show-stopper comments, I'd like to push this through jdk9/dev in 24 hours.
> Thanks,
> -Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20160127/8ca1d4a9/signature-0001.asc>

More information about the compiler-dev mailing list