JDK 9 request for specification changes of JDK-8032230: Enhance javax.a.p.RoundEnvironment after repeating annotations

[joe darcy]

Hi Bruce,

Thanks for the careful reading. Good catch on using "set" to describe 
the varargs array. To address this I propose the following patch which 
changes "set" to "array" for the one overload of 
getElementsAnnotatedWithAny which uses varargs:

--- 
a/src/java.compiler/share/classes/javax/annotation/processing/RoundEnvironment.java 
Thu Jun 02 17:31:38 2016 -0700
+++ 
b/src/java.compiler/share/classes/javax/annotation/processing/RoundEnvironment.java 
Sat Jun 11 12:18:44 2016 -0700
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 2005, 2007, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 2005, 2016, Oracle and/or its affiliates. All rights 
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -103,7 +103,7 @@
       *
       * @implSpec The default implementation of this method creates an
       * empty result set, iterates over the annotations in the argument
-     * set calling {@link #getElementsAnnotatedWith(TypeElement)} on
+     * array calling {@link #getElementsAnnotatedWith(TypeElement)} on
       * each annotation and adding those results to the result
       * set. Finally, the contents of the result set are returned as an
       * unmodifiable set.

-Joe


On 6/10/2016 6:56 PM, Bruce Chapman wrote:
> Joe,
>
> Just catching up on some reading, so this thread might be a bit stale 
> now.
>
> Anyway - your javadoc for both methods still talks about the argument 
> *set* in the @implSpec, which is now no longer a set since you changed 
> it to varargs.
>
> Otherwise it looks good.
>
> Bruce
>
>
> On 25/05/2016 4:18 a.m., joe darcy wrote:
>> Updated webrev:
>>
>>     http://cr.openjdk.java.net/~darcy/8032230.1/
>>
>> Now with specialized implementation in javac's implementation of
>> RoundEnvironment and separate tests of the default methods in the
>> interface and the javac implementation.
>>
>> Thanks,
>>
>> -Joe
>>
>
>
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>