RFR 8059631: Use of '#' to represent MethodHandle kind is confusing

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Mon Jun 20 09:43:02 UTC 2016


Approved!

Thanks
Maurizio

On 18/06/16 00:05, Jonathan Gibbons wrote:
> Updated webrev:
> http://cr.openjdk.java.net/~jjg/8059631/webrev.01
>
> -- Jon
>
> On 06/17/2016 03:53 PM, Jonathan Gibbons wrote:
>> I'll do a build and test run;  I think it should go if it is unused.
>>
>> I wasn't sure at first, since most of the names appear in the 3rd 
>> column of JVMS 8, Table 5.4.3.5-A
>> but the oddball is REF_newInvokeSpecial(8, "newinvokespecial") which 
>> isn't a JVMS name.
>>
>> -- Jon
>>
>> On 06/17/2016 03:40 PM, Maurizio Cimadamore wrote:
>>> Looks good - my IDE also tells me that RefKind.name is now unused? 
>>> Should it be dropped?
>>>
>>> Maurizio
>>>
>>> On 17/06/16 23:34, Jonathan Gibbons wrote:
>>>> Trivial review to "tweak" the presentation of method handles in 
>>>> javap's presentation of the constant pool.
>>>>
>>>> 1.  A misleading initial '#' is removed.
>>>> 2.  The description of the kind of MethHandle is changed to use the 
>>>> name given in the JVMS.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8059631
>>>> Webrev: http://cr.openjdk.java.net/~jjg/8059631/webrev
>>>>
>>>> -- Jon
>>>
>>
>



More information about the compiler-dev mailing list