RFR(s): JDK-8155026: javac grants implied readability to explicit modules
Jan Lahoda
jan.lahoda at oracle.com
Tue Jun 28 13:07:08 UTC 2016
On 27.6.2016 20:33, Jonathan Gibbons wrote:
> Generally looks good, but you might want to consider whether the test
> needs "@modules java.desktop". Will the test incorrectly fail if it is
> run on a basebones image, such as java.base + jdk.compiler?
I guess that for test selection purposes, it should include @modules
java.desktop. Updated webrev:
http://cr.openjdk.java.net/~jlahoda/8155026/webrev.01/
Delta:
http://cr.openjdk.java.net/~jlahoda/8155026/webrev.00-01/
Changes:
-added @module java.desktop
-removed an unnecessary -doe
-made the test method public
Does this look OK?
Thanks,
Jan
>
> -- Jon
>
> On 04/26/2016 12:38 AM, Jan Lahoda wrote:
>> Hi,
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8155026
>>
>> Fix/webrev:
>> http://cr.openjdk.java.net/~jlahoda/8155026/webrev.00/index.html
>>
>> Thanks,
>> Jan
>
More information about the compiler-dev
mailing list