RFR (S) 8151223: String concatenation fails with implicit toString() on package-private class

[Aleksey Shipilev]

On 03/08/2016 02:14 PM, Maurizio Cimadamore wrote:
> On 08/03/16 11:12, Maurizio Cimadamore wrote:
>>
>>
>> On 07/03/16 22:45, Aleksey Shipilev wrote:
>>> I don't think it was redundant: Object.class passes isAccessible check,
>>> and we exit the loop either with a concrete subclass of Object, or
>>> Object itself. But I agree we may want to check for Tag.NONE too.
>> Sorry - you are obviously right here - Object is always accessible, so
>> your code was indeed correct. Feel free to change it back if you like!
>>
>> Maurizio
> Also one last nit:
> 
> Type componentType = ((Type.ArrayType) originalType).getComponentType();
> 
> 
> getComponentType is an API method - there's an internal routine:
> Types.elemtype which works on any type, and thus you could avoid the cast.

Thanks Maurizio, fixed both nits:
  http://cr.openjdk.java.net/~shade/8151223/webrev.03/

-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20160308/b338e4b1/signature.asc>