RFR(XS): 8150632: jdk.jshell.TaskFactory should use jdk.Version to check for java.specification.version

[Volker Simonis]

PING!

Can I please have a review for this trivial change?

Thank you and best regards,
Volker


On Mon, Feb 29, 2016 at 10:20 AM, Volker Simonis
<volker.simonis at gmail.com> wrote:
> Also forwarding to kulla-dev which may be more appropriate than compiler-dev.
>
>
> ---------- Forwarded message ----------
> From: Volker Simonis <volker.simonis at gmail.com>
> Date: Thu, Feb 25, 2016 at 1:11 PM
> Subject: RFR(XS): 8150632: jdk.jshell.TaskFactory should use
> jdk.Version to check for java.specification.version
> To: compiler-dev at openjdk.java.net
>
>
> Hi,
>
> can I please have a review for the following small patch which fixes a
> problem with the jshell java.specification.version check:
>
> http://cr.openjdk.java.net/~simonis/webrevs/2016/8150632/
> https://bugs.openjdk.java.net/browse/JDK-8150632
>
> Currently, jdk.jshell.TaskFactory does a hard check against
> java.specification.version being "9". Until JDK-8149519 [1] will be
> resolved, this check will fail for any newer Java release (i.e.
> 9.0.0.1).
>
> But even if JDK-8149519 will be resolved, I think the compare should
> actually check that java.specification.version is greater or equal to
> "9". This can be easily done with the new jdk.Version API.
>
> Thank you and best regards,
> Volker
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8149519