RFR (S) 8151516: test/tools/javac/TestIndyStringConcat depends on runtime JDK details

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Wed Mar 9 14:00:14 UTC 2016

Looks good.

I've just noted that your test(s) are missing the @bug tag in the 
header. Please add one, and mention both this JBS issue and the one you 
fixed with your original patch. I.e. add

* @bug 8151516 8151223


On 09/03/16 13:07, Aleksey Shipilev wrote:
> Hi,
> I would like to clean up a basic TestIndyStringConcat test that
> validates ISC is enabled with different sources/targets and hidden
> compiler options. Alas, it makes that with prodding the stacktraces from
> JDK concat stub, which is implementation-specific:
>    https://bugs.openjdk.java.net/browse/JDK-8151516
> The solution is to look up the actual invokedynamic instructions:
>    http://cr.openjdk.java.net/~shade/8151516/webrev.01/
> (I have also added @clean tags in the related test)
> Thanks,
> -Aleksey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20160309/7b986efa/attachment.html>

More information about the compiler-dev mailing list