JDK 9 RFR of JDK-6415644 Make javax.lang.model.SourceVersion more informative
Jonathan Gibbons
jonathan.gibbons at oracle.com
Tue May 17 20:11:53 UTC 2016
Looks OK to me.
You could micro-optimize these lines
318 String id = s.toString();
319 if ("_".equals(id)) {
to use .contentEquals and aboid a possibly unnecessary .toString().
-- Jon
On 05/17/2016 11:48 AM, joe darcy wrote:
> Hello,
>
> Please review this webrev to add some version-sensitive keyword and
> name queries:
>
> JDK-6415644 Make javax.lang.model.SourceVersion more informative
>
> http://cr.openjdk.java.net/~darcy/6415644.0/
>
> Thanks,
>
> -Joe
>
More information about the compiler-dev
mailing list