JDK 9 RFR of JDK-8173609: Elements.printElements needs to support modules

joe darcy joe.darcy at oracle.com
Thu Feb 2 03:50:23 UTC 2017


Hi Bernard,

Just pushed your test under 8173798: Tests for printing modules.

Thanks again for the test,

-Joe


On 1/31/2017 4:59 AM, B. Blaser wrote:
> Hi Joe,
>
> 2017-01-31 0:15 GMT+01:00 Joseph D. Darcy <joe.darcy at oracle.com>:
>> Hi Bernard,
>>
>> Thanks for patch for the test.
>>
>> We've largely abandoned the bug number based scheme for categorizing tests;
>> it became cumbersome to find the tests we were looking for as the set of
>> tests grew.
>>
>> Since the functionality in question is related to the annotation processing
>> implementation in javac, I think a location under
>> test/tools/javac/processing/model/util would be more appropriate.
>>
>> Also for a source-based test, it would be more complete to also examine doc
>> comments and annotations. If you make those amendments, I can push the test
>> as follow-up work (since I've already pushed the code change).
>>
>> Thanks,
>>
>> -Joe
> Thanks for your comments.
> Please, find next the updated test.
>
> Bernard
>
>



More information about the compiler-dev mailing list