RFR 6388543: improve accuracy of source positions for AnnotationValue param of Messager.printMessage
Liam Miller-Cushon
cushon at google.com
Mon Feb 6 18:45:54 UTC 2017
Hi, have you had a chance to look at the latest version of the patch?
And would it make sense to defer to 10?
On Sat, Jan 14, 2017 at 3:37 PM, Liam Miller-Cushon <cushon at google.com>
wrote:
> On Thu, Jan 12, 2017 at 1:46 PM, Jonathan Gibbons <
> jonathan.gibbons at oracle.com> wrote:
>
>> Is there any good reason not to do so?
>
>
> I don't think so, thanks. I had thought that it would add implementation
> complexity and wasn't as obviously useful as supporting top-level and array
> elements values. However I realized that matchAnnoToTree can be generalized
> to search recursively for values, so it ends up being simpler. And as you
> point out, it offers the best flexibility.
>
> I have uploaded a new version of the patch that searches recursively:
> http://cr.openjdk.java.net/~cushon/6388543/webrev.01/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20170206/6c617657/attachment.html>
More information about the compiler-dev
mailing list