RFR JDK-8173777: Merge javac -Xmodule into javac--patch-module

Jan Lahoda jan.lahoda at oracle.com
Tue Feb 7 18:11:16 UTC 2017


Hi,

Thanks.

I did two small updates to the patches:
-for langtools repository, I added unwrapping to 
ClientCodeWrapper.WrappedJavaFileManager.getLocationForModule - the 
incoming JavaFileObject is unwrapped, so that we don't pass our wrappers 
to the client's code. Direct link:
http://cr.openjdk.java.net/~jlahoda/8173777/langtools.01/src/jdk.compiler/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java.udiff.html

-for jdk repository, I fixed the:
test/javax/xml/jaxp/common/8035437/run.sh
to use a platform specific path separator. This is based on code from 
jdk/test/java/lang/instrument/appendToClassLoaderSearch/CommonSetup.sh
Direct link:
http://cr.openjdk.java.net/~jlahoda/8173777/jdk.02/test/javax/xml/jaxp/common/8035437/run.sh.udiff.html

(Sorry that I missed this before.)

Updated webrevs:
-langtools repository:
http://cr.openjdk.java.net/~jlahoda/8173777/langtools.01/
-jdk repository:
http://cr.openjdk.java.net/~jlahoda/8173777/jdk.02/

Thanks,
    Jan

On 6.2.2017 21:42, Alan Bateman wrote:
>
>
> On 06/02/2017 18:41, Jan Lahoda wrote:
>> I've updated the jdk repository webrev to wrap long lines:
>> http://cr.openjdk.java.net/~jlahoda/8173777/jdk.01/
>>
>> Jan
> This looks okay to me.
>
> -Alan
>


More information about the compiler-dev mailing list