RFR: 8183505: Update langtools tests to allow for unique test classes directory

Jonathan Gibbons jonathan.gibbons at oracle.com
Tue Jul 4 13:23:02 UTC 2017



On 7/4/17 2:06 AM, Alan Bateman wrote:
> On 03/07/2017 21:36, Jonathan Gibbons wrote:
>> jtreg has been updated via CODETOOLS-7902003 [1] to use a unique 
>> test.classes directory. This is part of improving the reliability 
>> when running tests concurrently. The change exposes issues in a small 
>> number of tests in the hotspot, jdk, and langtools repos and these 
>> issues will need to be fixed before the requiredVersion can be bumped 
>> to use a promoted jtreg with this change.
>>
>> The few changes are all related to deriving the path for the library 
>> classes from test.class.path, instead of assuming a fixed 
>> relationship to the test's classes.
> Looks okay although some tests using endsWith whereas others use 
> getFileName().toString(). Either is fine of course.
>
> -Alan
Noted.   The tests using .endsWith were using Strings, the tests using 
getFileName().toString() were using Path ... but I see I can clean those 
up to use Path.endsWith as well.

-- Jon


More information about the compiler-dev mailing list