[8u] RFR for JDK-8180660: missing LNT entry for finally block

[Shafi Ahmad]

Thank you Maurizio.

May I get the 2nd thumps up.

Regards,
Shafi

> -----Original Message-----
> From: Maurizio Cimadamore
> Sent: Tuesday, June 06, 2017 3:25 PM
> To: Shafi Ahmad <shafi.s.ahmad at oracle.com>; compiler-
> dev at openjdk.java.net
> Cc: Vicente Romero Zaldivar <vicente.romero at oracle.com>
> Subject: Re: [8u] RFR for JDK-8180660: missing LNT entry for finally block
> 
> Looks good
> 
> Maurizio
> 
> 
> On 05/06/17 06:34, Shafi Ahmad wrote:
> > Hi,
> >
> > Please review the backport of bug: "JDK-8180660: missing LNT entry for
> finally block" to jdk8u-dev
> >
> > Please note that this is not a clean backport due to -
> > A) Compilation failure for file
> share/classes/com/sun/tools/javac/tree/TreeInfo.java.
> >       To make it compile we have made a code change in 'enum PosKind'.
> >       Thanks to Maurizio and Vicente for the help.
> > B) Compilation failure in file
> test/tools/javac/T8180660/MissingLNTEntryForFinalizerTest.java due to
> Module related code.
> >      +        void clear() {
> >      +            newRound();
> >      +            Modules.instance(context).newRound();
> >      +        }
> > I have modified the above method to
> >      +        void clear() {
> >      +            //do nothing
> >      +        }
> > ... and also removed all module related change.
> >
> > Webrev: http://cr.openjdk.java.net/~shshahma/8180660/webrev.00/
> > Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8180660
> > Original patch pushed to jdk10:
> http://hg.openjdk.java.net/jdk10/jdk10/langtools/rev/f52e81f886fb
> >
> > Test:  Run jprt, all langtools jtreg test, jtreg test under  jdk/test/java/util
> and jdk/test/java/lang and newly added test case.
> >
> > Regards,
> > Shafi
>