JDK-8176482: Use of DirectiveVisitor needs @DefinedBy annotation for RunCodingRules.java

joe darcy joe.darcy at oracle.com
Fri Mar 10 05:40:20 UTC 2017


Hello,

*sigh*

Sometimes it pays to run all the test, even ones where there is no way 
they could fail!

The patch below correct an oversight in the recently-pushed 8176477: 
"Use DirectiveVisitor to print module information" which neglected to 
include the @DefinedBy annotation it is use of the DirectiveVisitor type.

Thanks,

-Joe

--- 
a/src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java 
Thu Mar 09 18:33:47 2017 -0800
+++ 
b/src/jdk.compiler/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java 
Thu Mar 09 21:32:17 2017 -0800
@@ -334,7 +334,7 @@
                  this.writer = writer;
              }

-            @Override
+            @Override @DefinedBy(Api.LANGUAGE_MODEL)
              public Void visitExports(ExportsDirective d, Void p) {
                  // "exports package-name [to module-name-list]"
                  writer.print("exports ");
@@ -343,7 +343,7 @@
                  return null;
              }

-            @Override
+            @Override @DefinedBy(Api.LANGUAGE_MODEL)
              public Void visitOpens(OpensDirective d, Void p) {
                  // opens package-name [to module-name-list]
                  writer.print("opens ");
@@ -352,7 +352,7 @@
                  return null;
              }

-            @Override
+            @Override @DefinedBy(Api.LANGUAGE_MODEL)
              public Void visitProvides(ProvidesDirective d, Void p) {
                  // provides service-name with implementation-name
                  writer.print("provides ");
@@ -362,7 +362,7 @@
                  return null;
              }

-            @Override
+            @Override @DefinedBy(Api.LANGUAGE_MODEL)
              public Void visitRequires(RequiresDirective d, Void p) {
                  // requires (static|transitive)* module-name
                  writer.print("requires ");
@@ -374,7 +374,7 @@
                  return null;
              }

-            @Override
+            @Override @DefinedBy(Api.LANGUAGE_MODEL)
              public Void visitUses(UsesDirective d, Void p) {
                  // uses service-name
                  writer.print("uses ");



More information about the compiler-dev mailing list