JDK 8159439: NPEForModuleInfoWithNonZeroSuperClassTest updated

[B. Blaser]

On 16 March 2017 at 23:23, Maurizio Cimadamore
<maurizio.cimadamore at oracle.com> wrote:
>
>
> On 16/03/17 15:23, Jonathan Gibbons wrote:
>>
>> It sounds like build.xml should be updated to use the problem list.
>>
>> I don't how how common it is to use that target, which is probably
>> why this has slipped through.
>
> My bad - I did not update the target to use the problem list file when I
> wrote the new modularized ant build. I will look into this (for 10).
>
> Maurizio

Great!

I also had to include a "pathelement" to "asmtools.jar" as below
(which could eventually be pushed to 9 as it seems harmless). The
"timeoutFactor" isn't absolutely necessary but useful when the tests
are run on a slower CPU.

Bernard

diff --git a/make/build.xml b/make/build.xml
--- a/make/build.xml
+++ b/make/build.xml
@@ -332,6 +332,7 @@
             <classpath>
                 <pathelement location="${jtreg.home}/lib/jtreg.jar"/>
                 <pathelement location="${jtreg.home}/lib/javatest.jar"/>
+                <pathelement location="${jtreg.home}/lib/asmtools.jar"/>
             </classpath>
         </taskdef>
         <macrodef name="jtreg-tool">
@@ -359,6 +360,7 @@
                     agentvm="@{agentvm}" verbose="@{verbose}"
                     failonerror="false" resultproperty="jtreg.@{name}.result"
                     vmoptions="${coverage.options} @{extra.jvmargs}
${xpatch.noquotes.cmd}">
+                    <arg value="-timeoutFactor:5"/>
                     <arg value="-debug:@{jpda.jvmargs}"/>
                     <arg line="@{keywords}"/>
                     <arg line="@{options}"/>

>> If the test can be fixed and removed from the problem list, that
>> would be good.
>>
>> -- Jon
>>
>>
>> On 3/16/17 5:20 AM, B. Blaser wrote:
>>>
>>> Hi,
>>>
>>> I've noticed that running the javac tests using the "jtreg" target of
>>> "build.xml" seems not to take care of the "ProblemList.txt" (is this
>>> normal?). For example,
>>>
>>> tools/javac/modules/T8159439/NPEForModuleInfoWithNonZeroSuperClassTest.java
>>> is run and fails (but not with the expected output)...
>>>
>>> Nevertheless, the reason why it's on the problem list seems to be
>>> outdated as asmtools 6.0 includes the module handling. But a recent
>>> change in com.sun.tools.javac.jvm.ModuleNameReader.readModuleName()
>>> checks the "super_class" field when reading the module name. Which
>>> makes this test fail with another message as the expected one.
>>>
>>> I think this test could probably be removed from the "ProblemList.txt"
>>> and the expected output updated as below. Any comment is welcome.
>>>
>>> Thanks,
>>> Bernard
>>>
>>> diff --git
>>> a/test/tools/javac/modules/T8159439/NPEForModuleInfoWithNonZeroSuperClassTest.out
>>>
>>> b/test/tools/javac/modules/T8159439/NPEForModuleInfoWithNonZeroSuperClassTest.out
>>> ---
>>> a/test/tools/javac/modules/T8159439/NPEForModuleInfoWithNonZeroSuperClassTest.out
>>> +++
>>> b/test/tools/javac/modules/T8159439/NPEForModuleInfoWithNonZeroSuperClassTest.out
>>> @@ -1,2 +1,2 @@
>>> -- compiler.err.cant.access: mod.module-info,
>>> (compiler.misc.bad.class.file.header: module-info.class,
>>> (compiler.misc.module.info.invalid.super.class))
>>> +- compiler.err.cant.access: <error>.module-info,
>>> (compiler.misc.bad.class.file.header: module-info.class,
>>> (compiler.misc.module.name.mismatch: mod/module-info, <error>))
>>>   1 error
>>
>>
>