JDK 10 RFR of JDK-8191162: Use @implSpec tag for javax.lang.model.util visitor methods

Vicente Romero vicente.romero at oracle.com
Tue Nov 21 04:10:17 UTC 2017


Hi Joe,

I have reviewed the patch at 
http://cr.openjdk.java.net/~darcy/8191162.1/ and the CSR. Both look OK.

Thanks,
Vicente

On 11/19/2017 10:50 AM, joe darcy wrote:
> PS And corresponding CSR for review as well:
>
>     https://bugs.openjdk.java.net/browse/JDK-8191534
>
> Thanks,
>
> -Joe
>
>
> On 11/19/2017 6:49 AM, joe darcy wrote:
>> Hello,
>>
>> Please review the changes to address
>>
>>     JDK-8191162: Use @implSpec tag for javax.lang.model.util visitor 
>> methods
>>
>>     http://cr.openjdk.java.net/~darcy/8191162.1/
>>     http://cr.openjdk.java.net/~darcy/8191162.1-specdiff/
>>
>> As the title of the bug implies, the change attempts to more 
>> systematically use @implSpec tags in the various concrete visitor 
>> methods to separate out required behavior for the method and its 
>> overrides vs the specified behavior for a particular method in a class.
>>
>> Thanks,
>>
>> -Joe
>>
>



More information about the compiler-dev mailing list