RFR: 8182758: Remove the Native-Header Generation Tool (javah)
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Tue Nov 28 13:42:16 UTC 2017
Looks great. Only doubt: do we have enough tests for the javah
replacement? I see that this patch removes several tests and, while I
agree they don't make sense in the new, javac-driven world, I wonder if
some of those tests should be converted in order to stress similar edge
cases in the new counterpart. That said - the 'new' tests under
test/tools/javac/nativeHeaders/javahComparison/ seems very
comprehensive, so they probably already cover whatever was covered by
the old tests.
Maurizio
On 09/11/17 23:42, Jonathan Gibbons wrote:
> Please review a fix to remove the javah tool, as previously advertised
> in JDK-8152360. (The replacement is to use the javac -h option.)
>
> Not surprisingly, most of this is removing code, with just a couple of
> src/
> files being modified, as well as some tests.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8182758
> Webrev: http://cr.openjdk.java.net/~jjg/8182758/webrev.00/
>
> -- Jon
More information about the compiler-dev
mailing list