RFR 8189708: class reading issue with named and annotated parameters

Liam Miller-Cushon cushon at google.com
Fri Oct 20 16:30:12 UTC 2017

Thanks for the comments,

On Fri, Oct 20, 2017 at 12:28 AM, Jan Lahoda <jan.lahoda at oracle.com> wrote:
> -what happens if there are both runtime invisible and visible annotations
> of method's parameters? Seems those that appear later will overwrite those
> that appear sooner?

Oops, thanks. The way your patch handles that looks good to me.

> -the MethodSymbol.savedParameterAnnotations is only used during reading
> inside the ClassReader, right? It seems wasteful to have it as a field on
> each MethodSymbol, better would be a field in ClassReader.

Sounds good. I'll try to avoid having savedParameterNames as a field in
MethodSymbol also. Do you remember if you encountered any issues with that
in your patch?

> -please check what happens for annotations on constructors of
> enums/non-static innerclasses

Will do. (Also, note that there appears to be an issue with reading
MethodParameters on constructors of enums/non-static inner classes:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20171020/59074b36/attachment.html>

More information about the compiler-dev mailing list