RFR 8187247: canonical import check compares classes by simple name

[Liam Miller-Cushon]

Thanks!

On Fri, Oct 20, 2017 at 8:42 AM, Jan Lahoda <jan.lahoda at oracle.com> wrote:

> Hi Liam,
>
> Thanks for the ping. Seems OK. I'll push on Monday, unless someone else
> wants to.
>
> Jan
>
> On 19.10.2017 19:57, Liam Miller-Cushon wrote:
>
>> Friendly ping. Is this blocked on anything?
>>
>> On Mon, Sep 25, 2017 at 2:25 PM, Liam Miller-Cushon <cushon at google.com
>> <mailto:cushon at google.com>> wrote:
>>
>>     Hi Jan,
>>
>>     Thanks for the review. I moved the test to a directory.
>>
>>     Updated webrev:
>>     http://cr.openjdk.java.net/~cushon/8187247/webrev.01/
>>     <http://cr.openjdk.java.net/~cushon/8187247/webrev.01/>
>>     The formatted patch is attached.
>>
>>     On Thu, Sep 21, 2017 at 8:43 AM, Jan Lahoda <jan.lahoda at oracle.com
>>     <mailto:jan.lahoda at oracle.com>> wrote:
>>
>>         Hi Liam,
>>
>>         I apologize for belated answer. Seems OK to me, thanks for doing
>>         this. Only maybe put the test into a directory where it will be
>>         separate (e.g. importChecks/ImportCanonicalSameName) to avoid
>>         interference between this test and possible future tests.
>>
>>         Should I integrate this change?
>>
>>         Jan
>>
>>
>>         On 5.9.2017 18:58, Liam Miller-Cushon wrote:
>>
>>             This change fixes a bug that causes javac to incorrectly
>> accept
>>             non-canonical imports if the actual and expected symbols
>>             have the same
>>             simple name.
>>
>>             Bug: https://bugs.openjdk.java.net/browse/JDK-8187247
>>             <https://bugs.openjdk.java.net/browse/JDK-8187247>
>>             Webrev:
>>             http://cr.openjdk.java.net/~cushon/8187247/webrev.00/
>>             <http://cr.openjdk.java.net/~cushon/8187247/webrev.00/>
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20171023/955e9022/attachment.html>