RFR: 8214902: Pretty-printing marker annotations add unnecessary parenthesis

[Jonathan Gibbons]

Liam,

It is interesting to see the ongoing evolution of Pretty from what was 
originally an internal debug feature to something more useful. :-)

Just checking ... there seems to be two things going on in this review ...

1. You have improved Pretty and some obviously related tests, like 
*test/langtools/tools/javac/tree/TypeAnnotationsPretty.java*

2. You have separately chosen to tidy up the source code for a bunch of 
unrelated tests, by removing unnecessary parens from annotations.

Is that right?  I don't see that many of the modified tests are directly 
affected by the change.

(And, to be clear, I'm not objecting to the cleanup; I'm just calling it 
out as "convenient cleanup at this time".)

-- Jon

On 12/5/18 11:36 AM, Liam Miller-Cushon wrote:
> Hi,
>
> Please consider this small improvement to pretty-printing annotation 
> AST nodes, which omits the parens for marker annotations (e.g. `@A` 
> vs. `@A()`).
>
> webrev: http://cr.openjdk.java.net/~cushon/8214902/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8214902
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20181205/77ea98d1/attachment.html>