RFR: 8214902: Pretty-printing marker annotations add unnecessary parenthesis

Jonathan Gibbons jonathan.gibbons at oracle.com
Wed Dec 5 23:54:51 UTC 2018


Now, the cleanup is nice.

I'd suggest you put a note in the JBS issue, if there is nothing there 
already, saying this is an opportunity to cleanup the unnecessary parens 
in other tests.

Review looks good to me.

-- Jon

On 12/5/18 2:28 PM, Liam Miller-Cushon wrote:
> On Wed, Dec 5, 2018 at 12:42 PM Jonathan Gibbons 
> <jonathan.gibbons at oracle.com <mailto:jonathan.gibbons at oracle.com>> wrote:
>
>     1. You have improved Pretty and some obviously related tests, like
>     *test/langtools/tools/javac/tree/TypeAnnotationsPretty.java*
>
>     2. You have separately chosen to tidy up the source code for a
>     bunch of unrelated tests, by removing unnecessary parens from
>     annotations.
>
>     Is that right?  I don't see that many of the modified tests are
>     directly affected by the change.
>
>
> Yes, that's right: it was just as easy to clean up all of them, and I 
> figured the cleanup had some slight positive value.
>
> (If you'd prefer to avoid the churn I'm happy to back out the ones 
> that aren't required.)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20181205/3d45ba97/attachment-0001.html>


More information about the compiler-dev mailing list