RFR JDK-8208470: Type annotations on inner type that is an array component

[Liam Miller-Cushon]

On Thu, Dec 13, 2018 at 6:17 AM B. Blaser <bsrbnd at gmail.com> wrote:

> > As far as I can tell it's redundant. Adding the following assertion to
> `typeWithAnnotations` doesn't break any tests:
>
> Good, but this isn't a guarantee.
> If we want to clean up this part, I suggest to address this in a separate
> issue?
>

It might just be a signal that we need more test coverage here, but from
what I can tell the call sites to typeWithAnnotations all maintain that
invariant. There's some risk to changing the code, but leaving redundant
code in isn't necessarily safer if we don't understand why it's there and
it doesn't have test coverage.

I filed https://bugs.openjdk.java.net/browse/JDK-8215366 to look at that
part separately.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20181213/67f16333/attachment-0001.html>