RFR JDK-8214700: Compilation fails when extend and implement same method signature with generics

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Wed Dec 19 14:57:42 UTC 2018


I think it's better to leave this alone for the time being, until we 
have a clearer idea of what went wrong with 8207224; while the two fixes 
are mostly orthogonal, we don't want to introduce many type-system 
changes in related areas at the same time (esp. when there are failing 
tests), as that will make it very hard to troubleshoot problems.

Thanks
Maurizio

On 19/12/2018 14:46, B. Blaser wrote:
> Note that this fix works independently from JDK-8207224 and should be
> applied as the current behavior for the inherited implementation of an
> erased signature isn't orthogonal to the behavior for the direct
> implementation.
> Reverting the fix for JDK-8207224 would only remove some side-effects
> in some marginal cases (see my JBS comment), as expected?
>
> Shouldn't we go ahead with this one independently from JDK-8207224?
>
> Bernard
>
>
> On Wed, 19 Dec 2018 at 15:06, Vicente Romero <vicente.romero at oracle.com> wrote:
>> unfortunately the fix for JDK-8207224 has provoked several tests to
>> fail. I could be that we will need to delta apply it,
>>
>> Vicente
>>
>>
>> On 12/19/18 8:28 AM, B. Blaser wrote:
>>> Hi,
>>>
>>> The fix for JDK-8207224 being now integrated, please review the
>>> following fix for [1]:
>>>
>>> http://cr.openjdk.java.net/~bsrbnd/jdk8214700/webrev.00/
>>>
>>> which simply checks that return types are substitutable per JLS §8.4.5
>>> in both direct and inherited implementation.
>>>
>>> Thanks (tier1 is OK),
>>> Bernard
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8214700


More information about the compiler-dev mailing list