RFR JDK-8208470: Type annotations on inner type that is an array component

Liam Miller-Cushon cushon at google.com
Fri Dec 21 16:50:51 UTC 2018


It looks good to me. Thanks Bernard.

On Fri, Dec 21, 2018 at 4:28 AM B. Blaser <bsrbnd at gmail.com> wrote:

> On Thu, 13 Dec 2018 at 19:37, Liam Miller-Cushon <cushon at google.com>
> wrote:
> >
> > On Thu, Dec 13, 2018 at 6:17 AM B. Blaser <bsrbnd at gmail.com> wrote:
> >>
> >> If we want to clean up this part, I suggest to address this in a
> separate issue?
> >
> > I filed https://bugs.openjdk.java.net/browse/JDK-8215366 to look at
> that part separately.
>
> I re-based the fix on JDK-8215366, removed the assertion from
> 'arrayTypeTree' as you suggested earlier and returned the 'elemtype'
> directly as Werner suggested in [1]:
>
> http://cr.openjdk.java.net/~bsrbnd/jdk8208470/webrev.01/
>
> Does this look good (tier1 is still OK)?
>
> Thanks,
> Bernard
>
> [1]
> http://mail.openjdk.java.net/pipermail/compiler-dev/2018-July/012262.html
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20181221/521af25c/attachment.html>


More information about the compiler-dev mailing list