RFR: JDK-8190452: javac should not add MethodParameters attributes to v51 and earlier class files

[Vicente Romero]

Hi Liam,

The fix looks OK, regarding the test, I don't see the need for the two 
golden files as they can be constants in the test per se. In addition, 
the whole test could be self contained in only one class that compiles 
the Lib.java source. Regarding your questions about what to do with the 
-Xlint:X options. I don't have any opinion on one way or the other, is 
there any reason to change them?

Thanks,
Vicente

On 02/01/2018 01:56 PM, Liam Miller-Cushon wrote:
> Bump. I'm happy to implement either of the alternatives I mentioned, 
> but was hoping to get feedback on the approach first.
>
> On Wed, Jan 17, 2018 at 11:51 AM, Liam Miller-Cushon 
> <cushon at google.com <mailto:cushon at google.com>> wrote:
>
>     Please review a fix for JDK-8190452. The change causes javac to
>     not emit MethodParameters attributes when targeting v51 class files.
>
>     The change implements the suggestion from this thread:
>     http://mail.openjdk.java.net/pipermail/compiler-dev/2018-January/011579.html
>     <http://mail.openjdk.java.net/pipermail/compiler-dev/2018-January/011579.html>
>
>     There are two related changes that may be worth considering:
>     * now that -parameters will be ignored when compiling with
>     --release < 8, should this combination of flags result in a
>     warning if -Xlint:options is enabled?
>     * since this wasn't fixed in JDK 9, there are v51 class files in
>     the wild that contain unexpected MethodParameters attributes.
>     Should -Xlint:classfile be relaxed to avoid warning on those?
>
>     bug: https://bugs.openjdk.java.net/browse/JDK-8190452
>     <https://bugs.openjdk.java.net/browse/JDK-8190452>
>     webrev: http://cr.openjdk.java.net/~cushon/8190452/webrev.00/
>     <http://cr.openjdk.java.net/%7Ecushon/8190452/webrev.00/>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20180202/bf118e40/attachment.html>