Fixing JDK-8130493

[Jonathan Gibbons]

This problem just got more complicated.

It looks like you're reporting a problem in an older version of JDK. You 
reference com.sun.tools.javac.util.ServiceLoader, but that class no 
longer exists. (At this point in javac, it was a temporary "replacement" 
for java.util.ServiceLoader.)

So, that doesn't invalidate the general problem report, but it does mean 
that we are less likely to patch an older version for this issue.

-- Jon

On 01/09/2018 12:36 PM, Schaef, Martin wrote:
>
> It’s a user class. See full stack trace below.
>
> The problem is that the ClassNotFound is already caught at 
> com.sun.tools.javac.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:255) 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/file/989188d1a978/src/share/classes/com/sun/tools/javac/util/ServiceLoader.java#l257> 
> which already wraps it in a ServiceConfigurationError 
> <http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/file/989188d1a978/src/share/classes/com/sun/tools/javac/util/ServiceLoader.java#l100> 
> in the fail method. That is, the exception gets wrapped twice. First, 
> LazyIterator.next wraps it in a ServieConfigurationError, then 
> ServiceIterator.next wraps it in an Abort.
>
> Is it safe to change both wrappings?
>
> com.sun.tools.javac.util.Abort: java.lang.NoClassDefFoundError: 
> com/amazon/coral/util/reflection/AnnotatedManifestAnnotationProcessor
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment$ServiceIterator.next(JavacProcessingEnvironment.java:364)
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment$ServiceIterator.next(JavacProcessingEnvironment.java:325)
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:597)
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:690)
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment.access$1800(JavacProcessingEnvironment.java:91)
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1035)
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1176)
>
>     at 
> com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1170)
>
>     at 
> com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:856)
>
>     at com.sun.tools.javac.main.Main.compile(Main.java:523)
>
>     at com.sun.tools.javac.main.Main.compile(Main.java:381)
>
>     at com.sun.tools.javac.main.Main.compile(Main.java:370)
>
>     at com.sun.tools.javac.main.Main.compile(Main.java:361)
>
>     at com.sun.tools.javac.Main.compile(Main.java:56)
>
>     at com.sun.tools.javac.Main.main(Main.java:42)
>
> Caused by: java.lang.NoClassDefFoundError: 
> com/amazon/coral/util/reflection/AnnotatedManifestAnnotationProcessor
>
>     at java.lang.ClassLoader.defineClass1(Native Method)
>
>     at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
>
>     at 
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
>
>     at java.net.URLClassLoader.defineClass(URLClassLoader.java:467)
>
>     at java.net.URLClassLoader.access$100(URLClassLoader.java:73)
>
>     at java.net.URLClassLoader$1.run(URLClassLoader.java:368)
>
>     at java.net.URLClassLoader$1.run(URLClassLoader.java:362)
>
>     at java.security.AccessController.doPrivileged(Native Method)
>
>     at java.net.URLClassLoader.findClass(URLClassLoader.java:361)
>
>     at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>
>     at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>
>     at java.lang.Class.forName0(Native Method)
>
>     at java.lang.Class.forName(Class.java:348)
>
>     at 
> com.sun.tools.javac.util.ServiceLoader$LazyIterator.next(ServiceLoader.java:255)
>
>     at 
> com.sun.tools.javac.util.ServiceLoader$1.next(ServiceLoader.java:337)
>
>     at 
> com.sun.tools.javac.processing.JavacProcessingEnvironment$ServiceIterator.next(JavacProcessingEnvironment.java:359)
>
>     ... 14 more
>
> Caused by: java.lang.ClassNotFoundException: 
> com.amazon.coral.util.reflection.AnnotatedManifestAnnotationProcessor
>
>     at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>
>     at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>
>    at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>
> *From: *Jonathan Gibbons <jonathan.gibbons at oracle.com>
> *Date: *Tuesday, January 9, 2018 at 1:19 PM
> *To: *"Schaef, Martin" <schaef at amazon.com>, 
> "compiler-dev at openjdk.java.net" <compiler-dev at openjdk.java.net>
> *Subject: *Re: Fixing JDK-8130493
>
> What is the class triggering the ClassNotFoundException?
>
> If it is a user class not being found, it should be wrapped in a 
> ClientCodeException.   If it is a javac class not being found, it is 
> reasonable to wrap it in an Abort.
>
> -- Jon
>
> On 1/9/18 9:52 AM, Schaef, Martin wrote:
>
>     Hi,
>
>     We have some users suffering from JDK-8130493
>     <https://bugs.openjdk.java.net/browse/JDK-8130493> (their builds
>     succeed, but the compiler actually failed). I did some digging and
>     the following sequence happens:
>
>     A ClassNotFoundException is thrown in
>     JavaProcessingEnvironment.ServiceIterator.next()
>     <http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/file/989188d1a978/src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java#l364>
>     and re-thrown as an Abort.
>
>     This Abort reaches JavaCompiler.processAnnotations()
>     <http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/file/989188d1a978/src/share/classes/com/sun/tools/javac/main/JavaCompiler.java#l1170>
>     and is finally caught in JavaCompiler.compile()
>     <http://hg.openjdk.java.net/jdk8u/jdk8u/langtools/file/989188d1a978/src/share/classes/com/sun/tools/javac/main/JavaCompiler.java#l856> by
>     the following snippet:
>
>             try {
>
>     initProcessAnnotations(processors);
>
>                 // These method calls must be chained to avoid memory
>     leaks
>
>                 delegateCompiler =
>
>     processAnnotations( //<<<<<< ABORT COMES OUT HERE
>
>     enterTrees(stopIfError(CompileState.PARSE,
>     parseFiles(sourceFileObjects))),
>
>     classnames);
>
>     …
>
>             } catch (Abort ex) {
>
>                 if (devVerbose)
>
>     ex.printStackTrace(System.err);
>
>             } finally {
>
>     and swallowed ... but it's printed if XDev is set.
>
>     What is a proper way to fix this? Is it correct to wrap all
>     exceptions in JavaProcessingEnvironmentServiceIterator into
>     aborts? Or would it be better to distinguish different Aborts in
>     JavaCompiler.java?
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20180110/37d9b351/attachment-0001.html>