JDK 12 RFR of JDK-8206114: Refactor langtools/tools/javac/classfiles/ClassVersionChecker.java

[Jonathan Gibbons]

+1

There are opportunities for additional cleanup, maybe later, like 
whitespace fixes and using nio Files.writeFile etc. Also, the "-g" 
option for javac looks gratuitous.

-- Jon


On 6/30/18 9:45 AM, joe darcy wrote:
> Hello,
>
> Another day, another version-related test refactoring:
>
>     JDK-8206114: Refactor 
> langtools/tools/javac/classfiles/ClassVersionChecker.java
>     http://cr.openjdk.java.net/~darcy/8206114.0/
>
> I've verified the ease of maintenance of the test by removing the 
> TWELVE enum value and running the test against JDK 11.
>
> This is overlap in the test coverage of this test and other other test 
> out for review, but I haven't not tried to precisely determine or 
> eliminate that overlap.
>
> Thanks,
>
> -Joe
>