RFR: 8204630: generating an anonymous class with Filer#createClassFile causes an NPE in JavacProcessingEnvironment

[Jan Lahoda]

Seems fine to me.

Jan


5. července 2018 19:03:30 SELČ, Liam Miller-Cushon <cushon at google.com> napsal:
>Ping. Should I defer this to 12?
>
>On Thu, Jun 28, 2018 at 5:19 PM Liam Miller-Cushon <cushon at google.com>
>wrote:
>
>> Hi,
>>
>> Is there any more feedback on this?
>>
>> The bug is currently targeted for JDK 11, but I can defer it if there
>are
>> any concerns.
>>
>> Thanks,
>> Liam
>>
>> On Tue, Jun 12, 2018 at 7:50 PM Liam Miller-Cushon
><cushon at google.com>
>> wrote:
>>
>>> Hi Jan,
>>>
>>> Thanks for the review, and the explanation!
>>>
>>> On Tue, Jun 12, 2018 at 7:13 AM Jan Lahoda <jan.lahoda at oracle.com>
>wrote:
>>>
>>>> So the change in JavacProcessingEnvironment could be, I think,
>rewritten
>>>> as:
>>>> if (cs.owner.kind == PCK) {
>>>>      cs.owner.members().enterIfAbsent(cs);
>>>> }
>>>>
>>>
>>> Done.
>>>
>>> The change in ClassReader seems unnecessary, or am I mistaken?
>>>>
>>>
>>> Nope, I think you're right.
>>>
>>> Updated webrev:
>>> http://cr.openjdk.java.net/~cushon/8204630/webrev.01/
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20180705/48295273/attachment.html>