[12] (S) RFR 8206122 : Use Queue in place of ArrayList when need to remove first element

Martin Buchholz martinrb at google.com
Tue Jul 10 21:32:37 UTC 2018

I'm happy to see ArrayDeque replacing uses of ArrayList.

private final Map<List<String>, Deque<ReusableContext>>
options2Contexts = new HashMap<>();

Looks like these Deques are used only via the Queue interface. I would
either switch to Queue or to ArrayDeque (which might help the VM optimize).

On Tue, Jul 10, 2018 at 1:54 PM, Ivan Gerasimov <ivan.gerasimov at oracle.com>

> Hello!
> It is a tiny optimization.
> There are a couple of places where ArrayList is used as FIFO: elements are
> appended to the end, and removed from the head.
> ArrayDeque would be more efficient to use.
> Would you please help review?
> BUG: https://bugs.openjdk.java.net/browse/JDK-8206122
> Webrev: http://cr.openjdk.java.net/~igerasim/8206122/00/webrev/
> Thanks in advance!
> --
> With kind regards,
> Ivan Gerasimov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20180710/2899769f/attachment.html>

More information about the compiler-dev mailing list