JDK 12 RFR of JDK-8207055 : Make javac -help output for -source and -target more informative

[joe darcy]

Hi Jon,


On 7/11/2018 2:18 PM, Jonathan Gibbons wrote:
>
>
> On 07/11/2018 11:18 AM, joe darcy wrote:
>> Hello,
>>
>> Please review the changes to implement
>>
>>     JDK-8207055 : Make javac -help output for -source and -target 
>> more informative
>>     http://cr.openjdk.java.net/~darcy/8207055.1/
>>
>> Basically the -help output for -source and -target is augmented to 
>> include a concatenation of the supported values for those options. It 
>> would be possible to write the concatenation in a more stream-y 
>> manner, but I think the loops are sufficient.
>>
>> Thanks,
>>
>> -Joe
>>
>
> Joe,
>
> OK, but ...
>
> While not without precedent[1], the use of the string ", " to create a 
> string for a list is not correct in all locales.
>
> Perhaps separately, we should create and use a utility method to 
> convert a list to a string.
>
> -

Thanks for the review; adding a localized list-ifier javac utility 
method sounds like a good refactoring.

Cheers,

-Joe