RFR: JDK-8206874: Evaluate LoadClassFromJava6CreatedJarTest.java after dropping -source 6

[joe darcy]

Hi Vicente,

The current patch looks fine. It would arguably be more robust if min, 
max, and premax were computed more directly based on information from 
Source. For example, run a loop over the supported source values such as

             for(Source source :  Source.values()) {
                 if (source.isSupported())
                     supportedSources.add(source.name);
             }

and then populate min, max, and premax accordingly.

Thanks,

-Joe


On 7/19/2018 10:27 AM, Vicente Romero wrote:
> Hi all,
>
> Please review the patch to fix [1] at [2]. The fix is basically 
> removing the test as it is not useful anymore,
>
> Thanks,
> Vicente
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8206874
> [2] http://cr.openjdk.java.net/~vromero/8206874/webrev.00/jdk.dev.patch