RFR JDK-8206142: type inference: javac is incorrectly applying capture conversion during incorporation

B. Blaser bsrbnd at gmail.com
Sat Jul 21 14:13:02 UTC 2018


On 21 July 2018 at 15:49, B. Blaser <bsrbnd at gmail.com> wrote:
> Hi Vicente,
>
> On 20 July 2018 at 22:27, Vicente Romero <vicente.romero at oracle.com> wrote:
>> Hi all,
>>
>> Please review the patch to fix [1] at [2]. The fix is putting javac in sync
>> with the spec by not applying capture conversion during incorporation.
>>
>> Thanks,
>> Vicente
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8206142
>> [2] http://cr.openjdk.java.net/~vromero/8206142/webrev.00/jdk.dev.patch
>
> It's hard to measure the potential side-effects of this fix, but it
> seems good to me even if you'll probably need another review.
> Maybe, I'd rewrite it as next to avoid creating a new method?

My suggestion would miss 'checkUnsafeVarargsConversion()', so your
patch is better ;-)

Bernard

> Thanks,
> Bernard


More information about the compiler-dev mailing list