RFR: 8204630: generating an anonymous class with Filer#createClassFile causes an NPE in JavacProcessingEnvironment

Liam Miller-Cushon cushon at google.com
Wed Jun 13 02:50:59 UTC 2018


Hi Jan,

Thanks for the review, and the explanation!

On Tue, Jun 12, 2018 at 7:13 AM Jan Lahoda <jan.lahoda at oracle.com> wrote:

> So the change in JavacProcessingEnvironment could be, I think, rewritten
> as:
> if (cs.owner.kind == PCK) {
>      cs.owner.members().enterIfAbsent(cs);
> }
>

Done.

The change in ClassReader seems unnecessary, or am I mistaken?
>

Nope, I think you're right.

Updated webrev:
http://cr.openjdk.java.net/~cushon/8204630/webrev.01/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20180612/f7655337/attachment-0001.html>


More information about the compiler-dev mailing list