RFR: JDK-8205418: Assorted improvements to source code model

Vicente Romero vicente.romero at oracle.com
Thu Jun 21 15:01:03 UTC 2018


Hi,

The patch looks good but my recommendation would be to push it to 12 
first as it modifies some bits that have usually proven to be brittle. 
Let it bake in 12 for a while could be sensible,

Thanks,
Vicente

On 06/21/2018 07:43 AM, Jan Lahoda wrote:
> Hi,
>
> I'd like to propose a few improvements to the source code model as 
> seen through the com.sun.source APIs.
>
> The changes include better error recovery, a fix end positions, and a 
> fix for Trees.getScope when used with a TreePath that point to a block 
> of a lambda expression, including cases where there's an error in the 
> source code.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8205418
> Webrev: http://cr.openjdk.java.net/~jlahoda/8205418/webrev.00/
>
> How does this look?
>
> Thanks,
>    Jan



More information about the compiler-dev mailing list