JDK 12 RFR of JDK-8206085 : Refactor langtools/tools/javac/versions/Versions.java

[Remi Forax]

Hi Joe,
can you declare the instance fields of the enum 'final', thinking that there is a mutable enum constant somewhere make me sad.

regards,
Rémi

----- Mail original -----
> De: "joe darcy" <joe.darcy at oracle.com>
> À: "jonathan gibbons" <jonathan.gibbons at oracle.com>, "compiler-dev" <compiler-dev at openjdk.java.net>
> Envoyé: Vendredi 29 Juin 2018 21:41:31
> Objet: Re: JDK 12 RFR of JDK-8206085 : Refactor langtools/tools/javac/versions/Versions.java

> Dis-charged revision along with JDK 11 specific source example now up at
> 
>     http://cr.openjdk.java.net/~darcy/8206085.1/
> 
> Thanks,
> 
> -Joe
> 
> 
> On 6/29/2018 9:55 AM, Jonathan Gibbons wrote:
>> There's more static in this file than on my high-school Van de Graaf
>> generator!
>>
>> Can we follow the convention of creating an instance in main, and then
>> using instance methods.
>>
>> The naming of some methods is also novel, with respect to
>> case-conventions.
>>
>> -- Jon
>>
>>
>> On 6/28/18 8:15 PM, joe darcy wrote:
>>> Hello,
>>>
>>> Fresh off of updating
>>>
>>>     langtools/tools/javac/versions/Versions.java
>>>
>>> for the JDK 11 -> 12 transition, I'd like to refactor the test to
>>> reduce the maintenance needed when adding new versions (as in new
>>> releases) or removing versions (as is planned for later in JDK 12):
>>>
>>>     http://cr.openjdk.java.net/~darcy/8206085.0/
>>>
>>> Thanks,
>>>
>>> -Joe
>>>