RFR : JDK-8202387: javac --release 11 not supported

[Jan Lahoda]

Hi Rémi,

Thanks for the comments; updated webrev:
http://cr.openjdk.java.net/~jlahoda/8202387/code.02/

Jan

On 4.5.2018 18:09, Remi Forax wrote:
> Hi Jan,
> there is several occurences of Arrays.asList() that can be replaced by List.of() to make them really immutable.
>
> in CreateSymbols.java
>    in dumpCurrentClasses,
>       while ((read = in.read()) != (-1)) {
>         baos.write(read);
>       }
>     should be replaced by
>       in.transferTo(baos);
>
> in TransitiveDependencies.java,
>    - todo should be an ArrayDeque instead of a LinkedList, array based data structure are usually faster
>    - newBufferedWriter can takes only one argument
>
> in PreviewOptionTest.java,
>    - versionsToTest.stream().forEach can be replaced by versionsToTest.forEach
>
> regards,
> Rémi
>
> ----- Mail original -----
>> De: "jan lahoda" <jan.lahoda at oracle.com>
>> À: "jonathan gibbons" <jonathan.gibbons at oracle.com>, "compiler-dev" <compiler-dev at openjdk.java.net>,
>> build-dev at openjdk.java.net
>> Envoyé: Vendredi 4 Mai 2018 15:48:55
>> Objet: Re: RFR : JDK-8202387: javac --release 11 not supported
>
>> [+build-dev]
>>
>> On 4.5.2018 03:27, Jonathan Gibbons wrote:
>>> OK.
>>>
>>> It would be even better, perhaps in a subsequent update, if
>>> make/gendata/Gendata-jdk.compiler.gmk
>>> did not have to be updated for each release ... i.e. by changing A to B,
>>> and soon to C etc. The version
>>> letter can surely be inferred by the system.
>>
>> True. Updated webrevs:
>> http://cr.openjdk.java.net/~jlahoda/8202387/code.01/
>> (code changes, including update to Makefiles to automatically infer the
>> current JDK version)
>>
>> http://cr.openjdk.java.net/~jlahoda/8202387/data.01/
>> (historical data for JDK 10, similar patches will be needed for each new
>> JDK version)
>>
>> How does this look?
>>
>> Thanks,
>>      Jan
>>
>>>
>>> -- Jon
>>>
>>>
>>>
>>> On 05/03/2018 11:07 AM, Jan Lahoda wrote:
>>>> Hi,
>>>>
>>>> Bug:
>>>> https://bugs.openjdk.java.net/browse/JDK-8202387
>>>>
>>>> This patch adds historical data for JDK 10 and adds support for
>>>> --release 11.
>>>>
>>>> To simplify adding new platforms, the CreateSymbols tool is updated to
>>>> support incrementally adding platform support. So now it is possible
>>>> to run command like:
>>>> <jdk10>/bin/java <classpath-setup>
>>>> build.tools.symbolgenerator.CreateSymbols
>>>> build-description-incremental symbols include.list
>>>>
>>>> to add historical data for JDK 10. In the future it might even be
>>>> possible to use the source launcher so that one would not need to
>>>> compile the tool before use.
>>>>
>>>> The webrevs are split into two:
>>>> -updating the CreateSymbols tool, and adding a test that verifies that
>>>> "--release <current>" works (as suggested):
>>>> http://cr.openjdk.java.net/~jlahoda/8202387/code.00/
>>>> -actually adding the data for JDK 10, and adding --release 11:
>>>> http://cr.openjdk.java.net/~jlahoda/8202387/data.00/
>>>>
>>>> How does this look?
>>>>
>>>> Thanks,
>>>>      Jan