Test ReleaseOptionCurrent.java writes ReleaseOption.class in the source directory
Jonathan Gibbons
jonathan.gibbons at oracle.com
Thu May 17 17:27:54 UTC 2018
Jan,
Bernard's inline patch is OK by me
-- Jon
On 5/17/18 10:17 AM, Jan Lahoda wrote:
> Hi Bernard,
>
> Looks good to me. Thanks for working on this. If everyone agrees, I'll
> work on pushing this.
>
> Jan
>
> On 17.5.2018 18:28, B. Blaser wrote:
>> Hi Jon & David,
>>
>> Thanks for your feedback.
>>
>> On 17 May 2018 at 16:27, Jonathan Gibbons
>> <jonathan.gibbons at oracle.com> wrote:
>>> Bernard,
>>>
>>> Since you are using classes in the current directory, you do not
>>> need to
>>> clean the directory (jtreg runs tests in an empty directory) nor do
>>> you need
>>> to create the directory (javac now does that).
>>>
>>> -- Jon
>>
>> The fix is intended to put 'ReleaseOption.class' in the scratch
>> folder, the sub-directory 'classes' being probably unnecessary.
>> If I understand well Jon's explanation, simply '-d .' should make it
>> (as next), is that right?
>>
>> Thanks,
>> Bernard
>>
>>
>> diff -r 8e4fcfb4cfe4
>> test/langtools/tools/javac/options/release/ReleaseOptionCurrent.java
>> ---
>> a/test/langtools/tools/javac/options/release/ReleaseOptionCurrent.java
>> Thu May 17 10:32:26 2018 +0200
>> +++
>> b/test/langtools/tools/javac/options/release/ReleaseOptionCurrent.java
>> Thu May 17 18:03:14 2018 +0200
>> @@ -49,7 +49,7 @@
>> try (StandardJavaFileManager fm =
>> compiler.getStandardFileManager(null, null, null)) {
>> Iterable<? extends JavaFileObject> input =
>>
>> fm.getJavaFileObjects(System.getProperty("test.src") +
>> "/ReleaseOption.java");
>> - List<String> options = Arrays.asList("--release",
>> Source.DEFAULT.name);
>> + List<String> options = Arrays.asList("-d", ".",
>> "--release", Source.DEFAULT.name);
>>
>> boolean result = compiler.getTask(null, fm, null,
>> options, null, input).call();
>> if (!result) {
>>
More information about the compiler-dev
mailing list