RFR 8203436: javac should fail early when emitting illegal signature attributes

Vicente Romero vicente.romero at oracle.com
Mon May 21 18:06:07 UTC 2018


looks good,
Vicente

On 05/21/2018 01:33 PM, Maurizio Cimadamore wrote:
> I've prepared a new revision which contains a new test (this time for 
> intersection types leaking in sig attributes); I also moved the code 
> that checks for synthetic name clash from Check to Lower, closer to 
> the only point where it is used, to achieve better encapsulation.
>
> Webrev:
>
> http://cr.openjdk.java.net/~mcimadamore/8203436-v2/
>
> Maurizio
>
>
> On 18/05/18 19:12, Maurizio Cimadamore wrote:
>> Hi,
>> this patch makes javac a bit stricter when it comes to generating 
>> bytecode that has illegal signature attributes (which can happen in 
>> case of non-denotable types). Instead of allowing compilation and 
>> then fail at verify time, this patch issues an error message.
>>
>> I've refactored another generation-related diagnostic to share the 
>> same 'header' - an example of the diagnostics involved is included in 
>> the webrev.
>>
>> http://cr.openjdk.java.net/~mcimadamore/8203436/
>>
>> Cheers
>> Maurizio
>>
>



More information about the compiler-dev mailing list