RFR: 8202178(type.getKind() for var is None instead of Error)

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue May 22 20:47:06 UTC 2018


Hi,
the changes in MemberEnter look good (as they replicate more or less 
what happens in Attr.visitVarDef). That said, I'm not sure about the 
changes in Check - the routine you modified is only called when a 
variable has an initializer, which is not the case at least in the test 
you attached.

Also, since you are there, I suggest to enhance the test to try:

* 'var' field with regular initializer

* 'var' field with constant (e.g. string "Hello") initializer

* 'var' field with no initializer (as now)

Each of the above case goes through a slightly different code path.

Maurizio


On 22/05/18 18:32, Srinivas Dama wrote:
> Hi,
>
> Please review http://cr.openjdk.java.net/~sdama/8202178/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8202178
>
> Regards,
> Srinivas



More information about the compiler-dev mailing list