RFR: 8213908: AssertionError in DeferredAttr at setOverloadKind

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Tue Nov 20 11:55:41 UTC 2018


Looks good; I also wonder if it should be relaxed in the other direction 
too - e.g.

Assert.check(previous == ERROR || overloadKInd == ERROR || previous == 
overloadKind)

Maurizio

On 19/11/2018 21:39, Liam Miller-Cushon wrote:
> Hi,
>
> Please review this follow-up to JDK-8203679 and JDK-8210483, which 
> relaxes an assertion that was added by the earlier fixes.
>
> The intent of the assertion was to ensure that separate attribution 
> steps don't both succeed but determine different overload kinds for a 
> method reference, but the assertion was also failing if an earlier 
> attribution step succeeded and a later attribution step failed.
>
> webrev: http://cr.openjdk.java.net/~cushon/8213908/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8213908


More information about the compiler-dev mailing list