RFR: JDK-8206325: AssertionError in TypeSymbol.getAnnotationTypeMetadata

[Maurizio Cimadamore]

Looks sensible.

Thanks
Maurizio

On 29/11/2018 05:13, Srikanth wrote:
>
> Hello!,
>
> Please review the proposed fix for
>
>     https://bugs.openjdk.java.net/browse/JDK-8206325
>
> posted at:
>
>     http://cr.openjdk.java.net/~sadayapalam/JDK-8206325/webrev.00/
>
> Basically various parts of the compiler are ill prepared to handle the 
> scenario where a non-annotation type is treated erroneously as an 
> annotation. The present fix does two things: (a) "drops" the bogus 
> annotation (after suitable errors have been reported) rather than 
> persist in symbols. (b) since (a) is not enough to avoid trouble in 
> all cases, proactive checks to avoid tripping the land mines are also 
> put in place.
>
> In the normal course of things, this crash would never be reported to 
> users, since the compiler "swallows" crashes when an error has already 
> been reported - except when annotation processing is on (or when 
> -XDdev is used)
>
> Thanks!
> Srikanth