RFR: 8211057: Gensrc step CompileProperties generates unstable CompilerProperties output

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed Oct 3 10:21:51 UTC 2018


On 2018-10-02 18:38, Liam Miller-Cushon wrote:
> I noticed this earlier and the bug prompted me to actually do 
> something about it :)

Thank you Liam for fixing this!

/Magnus
>
> Thanks for the reviews.
>
> On Tue, Oct 2, 2018 at 6:11 AM Vicente Romero 
> <vicente.romero at oracle.com <mailto:vicente.romero at oracle.com>> wrote:
>
>     looks good,
>     Vicente
>
>     On 10/02/2018 12:26 AM, Liam Miller-Cushon wrote:
>>     Hi,
>>
>>     Please review this fix to ClassGenerator, which ensures it
>>     produces deterministic output.
>>     Previously the order of FactoryKinds in the output relied on
>>     HashMap iteration order.
>>
>>     bug: https://bugs.openjdk.java.net/browse/JDK-8211057
>>     webrev:
>>     http://cr.openjdk.java.net/~cushon/8211057/webrev.00/index.html
>>     <http://cr.openjdk.java.net/%7Ecushon/8211057/webrev.00/index.html>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20181003/0fad431a/attachment-0001.html>


More information about the compiler-dev mailing list