RFR: JDK-8210009: Source Launcher classloader should support getResource and getResourceAsStream

mandy chung mandy.chung at oracle.com
Thu Sep 6 20:10:00 UTC 2018

On 9/5/18 12:08 PM, Jonathan Gibbons wrote:
> Updated webrev, addressing comments from Peter.
> 1. Fixed protocol string, and updated test to verify that URLs are OK
> 2. Changed init of the stream handler
> Webrev: http://cr.openjdk.java.net/~jjg/8210009/webrev.02/

The updated webrev looks okay.

The test now verifies URL.toURI() - that's good (I mixed that in my 
review). The formatting in src/CLTest.java seems to need some clean up 
(the identation) - no need for a new webrev.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20180906/2a1e330b/attachment.html>

More information about the compiler-dev mailing list