RFR 8222806: Inefficient String.replace in PathFileObject.toBinaryName

Ron Shapiro ronshapiro at google.com
Mon Apr 22 18:07:34 UTC 2019

I mentioned in the bug that it had a 300ms improvement for a 30s build.

I think it would be reasonable in String.replace() if it was common enough
to be worth checking the lengths. I don't know what the benchmarking
considerations are there.

On Mon, Apr 22, 2019 at 2:03 PM Jonathan Gibbons <
jonathan.gibbons at oracle.com> wrote:

> That seems like micro-optimization.  Do you have numbers to back it up?
> Should this sort of optimization be done in String.replace?
> -- Jon
> On 4/22/19 8:51 AM, Ron Shapiro wrote:
> Hi,
> Please review this small change to improve the performance of
> PathFileObject.toBinaryName:
> webrev: http://cr.openjdk.java.net/~ronsh/8222806/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8222806
> Thanks!
> Ron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/compiler-dev/attachments/20190422/3f92b8c5/attachment.html>

More information about the compiler-dev mailing list