JDK 13 RFR of JDK-8146726 : Improve AbstractProcessor to issue warnings for repeated information
Jonathan Gibbons
jonathan.gibbons at oracle.com
Thu Apr 25 23:59:52 UTC 2019
There's bad indentation on line 199.
What about localization for the inline English strings?
-- Jon
On 4/25/19 8:56 AM, Joe Darcy wrote:
> PS Amended webrev at
>
> http://cr.openjdk.java.net/~darcy/8146726.5/
>
> I added a bit of logic to avoid issuing a duplicate warning when the
> module name is stripped off to avoid spurious warnings in a case like
>
> "foo/a.B" "bar/a.B"
>
> The intention of the revision of the semantics of this method in JDK 9
> was to allow convenient and warning-free usage with and without modules.
>
> Thanks,
>
> -Joe
>
> On 4/24/2019 7:08 PM, Joe Darcy wrote:
>> Hello,
>>
>> Returning to JDK-8146726, based on previous review feedback I've
>> changed the title to "Improve AbstractProcessor to issue warnings for
>> repeated information" and reworked the fix:
>>
>> http://cr.openjdk.java.net/~darcy/8146726.4/
>>
>> Thanks,
>>
>> -Joe
>>
>>
More information about the compiler-dev
mailing list