JDK 13 RFR of JDK-8146726 : Improve AbstractProcessor to issue warnings for repeated information

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Apr 29 14:33:44 UTC 2019


OK, it's a bit of a fine distinction between libraries and javac in this 
case, but you point to precedent.

OK by me,

-- Jon

On 4/25/19 5:42 PM, Joe Darcy wrote:
> Hi Jon,
>
> On 4/25/2019 4:59 PM, Jonathan Gibbons wrote:
>> There's bad indentation on line 199.
>
> Noted; will fix.
>
>>
>> What about localization for the inline English strings?
>
> We haven't supported localization of error/warning message from the 
> libraries in contrast with the localization policies for javac.
>
> For example, getSupportedSourceVersion can generate a non-localized 
> warning as can getSupportedAnnotationTypes for a different situation.
>
> I would view adding localization as out-of-scope for this particular 
> changeset, but something we could consider as a future enhancement.
>
> Thanks,
>
> -Joe
>
>


More information about the compiler-dev mailing list