RFR 8230162: ScopeImpl.remove() has O(N) performance

Jonathan Gibbons jonathan.gibbons at oracle.com
Mon Aug 26 16:38:21 UTC 2019


Do you have any estimates of the increase in size in typical usage, due 
to the extra field in Scope?

Since DPrinter is explicitly a "debug printer", you want consider 
tweaking it to show both the prev and next sibilings.

-- Jon

On 8/26/19 9:12 AM, Ron Shapiro wrote:
> Hi
>
> Please review the following patch to address O(N) performance in 
> ScopeImpl.remove().
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8230162
> webrev: http://cr.openjdk.java.net/~ronsh/8230162/webrev.00/
>
> Note that the patch was prepared by my coworker, Brad (cc'd). I wasn't 
> sure what to do to make sure that he was attributed correctly.
>
> Thanks,
> Ron


More information about the compiler-dev mailing list