RFR: JDK-8233524: Wrong module name for "package P is declared in the unnamed module, but module M does not read it"

[Jonathan Gibbons]

Good catch; looks OK to me.

-- Jon

On 11/28/19 8:43 AM, Jan Lahoda wrote:
> Hi,
>
> There is a small mistake (with bad consequences) in compiler.properties:
> ---
> # {0} - package in which the invisible class is declared
> # {1} - current module
> # 0: symbol, 1: symbol
> compiler.misc.not.def.access.does.not.read.unnamed=\
>     package {0} is declared in the unnamed module, but module {0} does 
> not read it
> ---
>
> Note the use of {0} after module - but based on the comment above (and 
> the code that uses this error message), the module is in {1}. The 
> proposal is to simply fix this as:
> ---
> # {0} - package in which the invisible class is declared
> # {1} - current module
> # 0: symbol, 1: symbol
> compiler.misc.not.def.access.does.not.read.unnamed=\
>     package {0} is declared in the unnamed module, but module {1} does 
> not read it
> ---
>
> Webrev: http://cr.openjdk.java.net/~jlahoda/8233524/webrev.00/
> JBS: https://bugs.openjdk.java.net/browse/JDK-8233524
>
> How does this look?
>
> Thanks,
>     Jan