RFR: JDK-8234689 facilitate writing additional custom attributes in a class file

Jonathan Gibbons jonathan.gibbons at oracle.com
Fri Dec 6 22:10:39 UTC 2019


Updated webrev:

Webrev: http://cr.openjdk.java.net/~jjg/8234689/webrev.01/

-- Jon


On 12/06/2019 01:19 PM, Jonathan Gibbons wrote:
> Hi Jan,
>
> Yes, it did occur to me after the fact that we could keep the existing 
> method if we wanted to.  I'll put it back and update the test.
>
> -- Jon
>
>
> On 12/05/2019 11:57 PM, Jan Lahoda wrote:
>> Overall looks OK to me. Not sure if it would make sense to keep the 
>> existing method? The test will need tweaks for @bug and @summary.
>>
>> Jan
>>
>> On 06. 12. 19 3:23, Jonathan Gibbons wrote:
>>> Please review a small change to javac to permit friendly clients to 
>>> inject additional attributes into a class file.
>>>
>>> This supersedes and generalizes an existing mechanism which is 
>>> difficult/impractical to use, especially
>>> in current versions of javac where split packages are strongly 
>>> discouraged.
>>>
>>> -- Jon
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8234689
>>> Webrev: http://cr.openjdk.java.net/~jjg/8234689/webrev.00/
>>>
>



More information about the compiler-dev mailing list